linux-kernel - Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x OOPS!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201301092041.18888.PeterHuewe@gmx.de>
Date:	Wed, 9 Jan 2013 20:41:18 +0100
From:	Peter Hüwe <PeterHuewe@....de>
To:	tpmdd-devel@...ts.sourceforge.net
Cc:	Mathias LEBLANC <Mathias.LEBLANC@...com>,
	Kent Yoder <key@...ux.vnet.ibm.com>,
	"Jean-Luc BLANC" <jean-luc.blanc@...com>,
	"Sirrix@...per.es" <Sirrix@...per.es>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kent Yoder <shpedoikal@...il.com>
Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x OOPS!

Hi,

> Do you have the I2C configuration activated ?
> I have this error when I add the driver in a kernel with no I2C activated

I2C works fine on my beaglebone, however  I did not add the platform data to my 
boardfile.
a) as I don't use board files anymore but device trees ;)
b) it's perfectly legit to load a driver without the platform data and probe 
it at runtime (which then in doubt fails to probe).

In my opinion a driver should never ever oops, even if the user does something 
stupid (e.g. like probing from userspace ;)

The fix is as simple as adding a simple 
if (!platform_data) return -ENODEV;
or something similar.

Thanks,
Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/