linux-kernel - RE: [PATCH] Bluetooth: btmrvl_sdio: look for sd8688 firmware in alternate place

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <477F20668A386D41ADCC57781B1F70430D13FDB783@SC-VEXCH1.marvell.com>
Date:	Tue, 8 Jan 2013 18:43:23 -0800
From:	Bing Zhao <bzhao@...vell.com>
To:	Marcel Holtmann <marcel@...tmann.org>,
	Lubomir Rintel <lkundrak@...sk>
CC:	David Woodhouse <dwmw2@...radead.org>,
	Ben Hutchings <ben@...adent.org.uk>,
	"libertas-dev@...ts.infradead.org" <libertas-dev@...ts.infradead.org>,
	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
	Gustavo Padovan <gustavo@...ovan.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Bluetooth: btmrvl_sdio: look for sd8688 firmware in
 alternate place


> > linux-firmware ships the sd8688* firmware images that are shared with
> > libertas_sdio WiFi driver under libertas/. libertas_sdio looks in both places
> > and so should we.
> >
> > Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> > ---
> >  drivers/bluetooth/btmrvl_sdio.c |   24 ++++++++++++++++++++++--
> >  drivers/bluetooth/btmrvl_sdio.h |    6 ++++--
> >  2 files changed, 26 insertions(+), 4 deletions(-)
> 
> NAK from me on this one. I do not want the driver to check two
> locations. That is what userspace can work around.
> 
> If we want to unify the location between the WiFi driver and the
> Bluetooth driver, I am fine with that, but seriously, just pick one over
> the other. I do not care which one.

The unified location is mrvl/ directory.

We can probably move SD8688 firmware & helper binaries to mrvl/ and have both drivers grab the images there?

Regards,
Bing