lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <201301092233.10166.arnd@arndb.de>
Date:	Wed, 9 Jan 2013 22:33:09 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	arve@...roid.com, x86@...nel.org, linux-kernel@...r.kernel.org,
	mikechan@...gle.com
Subject: Re: [PATCH 03/10] goldfish: tty driver

On Wednesday 09 January 2013, Alan Cox wrote:
> +static int __devinit goldfish_tty_probe(struct platform_device *pdev)
> +{
> +       struct goldfish_tty *qtty;
> ...
> +
> +static int __init goldfish_tty_init(void)
> +{
> +       return platform_driver_register(&goldfish_tty_platform_driver);
> +}
> +
> +static void __exit goldfish_tty_exit(void)
> +{
> +       platform_driver_unregister(&goldfish_tty_platform_driver);
> +}
> +
> +module_init(goldfish_tty_init);
> +module_exit(goldfish_tty_exit);

The same comments on __devinit/__devexit and module_platform_driver
that I made on the bus driver apparently apply on this patch and
some of the others.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ