lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAH7P7NjdKsWjttmWyKxttm=rJDAErZxe7+Zf_oaSCx6Pmc1GWw@mail.gmail.com> Date: Thu, 10 Jan 2013 09:52:36 +0100 From: Laurent Navet <laurent.navet@...il.com> To: Jean Delvare <khali@...ux-fr.org> Cc: w.sang@...gutronix.de, ben-linux@...ff.org, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] drivers: i2c-nforce2: fix coding style issues Hi Jean, > > Unfortunately your patch also add one new checkpatch.pl warning: > > WARNING: line over 80 characters > #245: FILE: drivers/i2c/busses/i2c-nforce2.c:272: > + data->word = inb_p(NVIDIA_SMB_DATA) | (inb_p(NVIDIA_SMB_DATA + 1) << 8); > > Please fix. > > As mentioned previously, __devinit has been dropped meanwhile, so this > change doesn't apply cleanly. Please rebase your patch on top of kernel > 3.8-rc3 (or Wolfram's i2c tree) so that Wolfram can apply it. > > All the rest looks very good now, thanks for the good work. I've worked and tested against git.pengutronix.de wsa/linux.git ( http://git.pengutronix.de/?p=wsa/linux.git;a=summary ) Isnt' it the right one ? -- Laurent. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists