linux-kernel - Re: clk dereference in arch/sh/kernel/cpufreq.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1301101031290.2063@localhost6.localdomain6>
Date:	Thu, 10 Jan 2013 10:31:46 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Paul Mundt <lethal@...ux-sh.org>
cc:	linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: clk dereference in arch/sh/kernel/cpufreq.c

On Thu, 10 Jan 2013, Paul Mundt wrote:

> On Thu, Jan 03, 2013 at 10:40:20AM +0100, Julia Lawall wrote:
> > There has been a discussion recently about how the result of get_clk
> > should be an opaque handle, not a value that can be dereferenced:
> > 
> > https://lkml.org/lkml/2012/12/20/105
> > 
> > There is such a dereference in arch/sh/kernel/cpufreq.c, in the function
> > sh_cpufreq_cpu_init:
> > 
> > freq_table = cpuclk->nr_freqs ? cpuclk->freq_table : NULL;
> > 
> > It was not obvious to me, however, what API function should be used
> > instead, so I am just reporting the (potential) problem.
> > 
> In this case we would have to add some new API for fetching the frequency
> table associated with the struct clk, which is reasonably
> straightforward. It's not obvious how a private API vs deref of a type we
> have a private definition for is any better or worse, though. This code
> is not aimed at the common struct clk in any event.

OK, maybe it should just be left as is?

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/