linux-kernel - Re: redefinition of devm_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdV9tZZ94QuCcyYCwgZZN9du48vq-h7++1aVjPKZ79d-Qg@mail.gmail.com>
Date:	Thu, 10 Jan 2013 11:52:44 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	linux-kernel@...r.kernel.org
Subject: Re: redefinition of devm_gpio_request

On Thu, Jan 10, 2013 at 10:46 AM, Linus Walleij
<linus.walleij@...aro.org> wrote:
> On Sun, Dec 16, 2012 at 2:11 PM, Geert Uytterhoeven
> <geert@...ux-m68k.org> wrote:
>> On current linus/HEAD, m68k allmodconfig gives:
>> drivers/gpio/devres.c:52: error: redefinition of ‘devm_gpio_request’
>> include/linux/gpio.h:99: error: previous definition of
>> ‘devm_gpio_request’ was here
>> drivers/gpio/devres.c:82: error: redefinition of ‘devm_gpio_request_one’
>> include/linux/gpio.h:111: error: previous definition of
>> ‘devm_gpio_request_one’ was here
>> drivers/gpio/devres.c:114: error: redefinition of ‘devm_gpio_free’
>> include/linux/gpio.h:129: error: previous definition of
>> ‘devm_gpio_free’ was here
>> make[5]: *** [drivers/gpio/devres.o] Error 1
>>
>> The !CONFIG_GENERIC_GPIO dummy definitions in include/linux/gpio.h conflict
>> with the real ones in drivers/gpio/devres.c.
>> Should devres.c really be compiled if !CONFIG_GENERIC_GPIO?
>
> I've looked at it but I just can't figure this one out :-(
>
> obj-$(CONFIG_GPIOLIB)           += gpiolib.o devres.o
>
> GPIOLIB selects GENERIC_GPIO.
>
> So this *should* not be compiled unless GENERIC_GPIO is also
> selected.

I guess it was caused by ssb/bcma selecting GPIOLIB, which got fixed in the
mean time.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/