linux-kernel - Re: [PATCH v3] gpio: twl4030: Cache the direction and output states in private data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50EEBD8F.6040101@ti.com>
Date:	Thu, 10 Jan 2013 14:09:35 +0100
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	Grant Likely <grant.likely@...retlab.ca>,
	Michael Trimarchi <michael@...rulasolutions.com>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH v3] gpio: twl4030: Cache the direction and output states
 in private data

Hi Linus,

On 01/10/2013 11:41 AM, Linus Walleij wrote:
> On Thu, Dec 20, 2012 at 10:44 AM, Peter Ujfalusi <peter.ujfalusi@...com> wrote:
> 
>> Use more coherent locking in the driver. Use bitfield to store the GPIO
>> direction and if the pin is configured as output store the status also in a
>> bitfiled.
>> In this way we can just look at these bitfields when we need information
>> about the pin status and only reach out to the chip when it is needed.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
>> Acked-by: Linus Walleij <linus.walleij@...aro.org>
>> ---
>> Hi Grant,
>>
>> Changes sicne v2:
>> - Fixed the mutex_unlock found by Michael.
>> - Removed the debug prints addedd by v2 patch (remains from debugging)
>> - Removed one blank line between includes and the first comment section.
> 
> Sorry Peter this must have been missed somehow.
> 
> This does not apply to the current v3.8-rc3, could you respin
> this on top of Torvalds' tree?

Grant applied the patch which this one depends on:
[1] https://patchwork.kernel.org/patch/1844511/

Not sure where.
There were a third patch in v2 as well. I'm not sure about the status of that.

[1] + this patch applies cleanly on top of mainline.

Should I resend the series as v4 for your convenience?

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/