linux-kernel - Re: [PATCH v3 15/44] metag: Huge TLB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50EEF2E9.2080302@linux.vnet.ibm.com>
Date:	Thu, 10 Jan 2013 08:57:13 -0800
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	James Hogan <james.hogan@...tec.com>
CC:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH v3 15/44] metag: Huge TLB

On 01/10/2013 07:30 AM, James Hogan wrote:
> +pte_t *huge_pte_alloc(struct mm_struct *mm,
> +			unsigned long addr, unsigned long sz)
> +{
> +	pgd_t *pgd;
> +	pud_t *pud;
> +	pmd_t *pmd;
> +	pte_t *pte;
> +
> +	pgd = pgd_offset(mm, addr);
> +	pud = pud_offset(pgd, addr);
> +	pmd = pmd_offset(pud, addr);
> +	pte = pte_alloc_map(mm, NULL, pmd, addr);
> +	pgd->pgd &= ~_PAGE_SZ_MASK;
> +	pgd->pgd |= _PAGE_SZHUGE;
> +
> +	return pte;
> +}

I'd be a bit surprised if you don't have to check for NULL during the
walk down the page tables.  Is there a special reason on your
architecture that this is unnecessary?

(There are several of these, not just this one).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/