linux-kernel - Re: Pull "Load keys from signed PE binaries" branch into linux-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1656.1357841800@warthog.procyon.org.uk>
Date:	Thu, 10 Jan 2013 18:16:40 +0000
From:	David Howells <dhowells@...hat.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	dhowells@...hat.com, LKML <linux-kernel@...r.kernel.org>
Subject: Re: Pull "Load keys from signed PE binaries" branch into linux-next


> > More of my paranoia for array access here. :)
>
> I've added this at the top of pkc7_digest():
> 
> 	if (pkcs7->sig.pkey_hash_algo > PKEY_HASH__LAST ||
> 	    pkey_hash_algo_name[pkcs7->sig.pkey_hash_algo])

There should be a '!' here.

> 		return -ENOPKG;

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/