linux-kernel - Re: linux-next: Tree for Jan 10 (staging/sb105x)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1357851057.5141.16.camel@gandalf.local.home>
Date:	Thu, 10 Jan 2013 15:50:57 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: linux-next: Tree for Jan 10 (staging/sb105x)

On Thu, 2013-01-10 at 11:08 -0800, Randy Dunlap wrote:
> On 01/09/13 19:32, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20130109:
> > 
> 
> on x86_64, when CONFIG_PARPORT_PC is not enabled:
> 
> drivers/built-in.o: In function `multi_init':
> sb_pci_mp.c:(.init.text+0x15684): undefined reference to `parport_pc_probe_port'
> 
> 
> Full randconfig file is attached.

Ug, so https://lkml.org/lkml/2012/12/14/250 should have been
CONFIG_PARPORT_PC and not just PARPORT :-P

Can you try this patch:

diff --git a/drivers/staging/sb105x/sb_pci_mp.c b/drivers/staging/sb105x/sb_pci_mp.c
index 131afd0c..9464f38 100644
--- a/drivers/staging/sb105x/sb_pci_mp.c
+++ b/drivers/staging/sb105x/sb_pci_mp.c
@@ -3054,7 +3054,7 @@ static int init_mp_dev(struct pci_dev *pcidev, mppcibrd_t brd)
 				sbdev->nr_ports = ((portnum_hex/16)*10) + (portnum_hex % 16);
 			}
 			break;
-#ifdef CONFIG_PARPORT
+#ifdef CONFIG_PARPORT_PC
 		case PCI_DEVICE_ID_MP2S1P :
 			sbdev->nr_ports = 2;
 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/