lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130110230121.GA20584@quad.lixom.net> Date: Thu, 10 Jan 2013 15:01:21 -0800 From: Olof Johansson <olof@...om.net> To: Doug Anderson <dianders@...omium.org> Cc: linux-mmc@...r.kernel.org, linux-samsung-soc@...r.kernel.org, Thomas Abraham <thomas.abraham@...aro.org>, Kukjin Kim <kgene.kim@...sung.com>, Arnd Bergmann <arnd@...db.de>, Will Newton <will.newton@...tec.com>, Chris Ball <cjb@...top.org>, Jaehoon Chung <jh80.chung@...sung.com>, Seungwon Jeon <tgih.jun@...sung.com>, linux-kernel@...r.kernel.org, Grant Likely <grant.likely@...retlab.ca>, Rob Herring <rob.herring@...xeda.com>, Rob Landley <rob@...dley.net>, Abhilash Kesavan <a.kesavan@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com>, devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org Subject: Re: [REPOST PATCH v3 1/4] mmc: dw_mmc: Add "disable-wp" device tree property On Thu, Jan 10, 2013 at 10:24:26AM -0800, Doug Anderson wrote: > The "disable-wp" property is used to specify that a given SD card slot > doesn't have a concept of write protect. This eliminates the need for > special case code for SD slots that should never be write protected > (like a micro SD slot or a dev board). > > The dw_mmc driver is special in needing to specify "disable-wp" > because the lack of a "wp-gpios" property means to use the special > purpose write protect line. On some other mmc devices the lack of > "wp-gpios" means that write protect should be disabled. Hi, The previous code used the controller-common quirk field to set a per-controller DW_MCI_QUIRK_NO_WRITE_PROTECT. Is there really need to do this per-slot? And if so, please explain in the commit message why there is need for a brand new quirk for the same functionality. It's even uncertain if there are any systems out there that uses the multi-slot functionality of this driver to date, most seem to map one slot per controller in the first place... -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists