linux-kernel - Re: [PATCH resend 2/2] Input: twl6040-vibra: Code cleanup in probe with devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50EFD728.8090204@ti.com>
Date:	Fri, 11 Jan 2013 10:11:04 +0100
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	<linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH resend 2/2] Input: twl6040-vibra: Code cleanup in probe
 with devm_* conversion

Hi Dmitry,

On 01/10/2013 06:54 PM, Dmitry Torokhov wrote:
> Hi Peter,
> 
> On Thu, Jan 10, 2013 at 02:36:05PM +0100, Peter Ujfalusi wrote:
>> Convert the probe to use devm_*. At the same time reorder the calls
>> so we will register the input device as the last step when the driver
>> is loaded.
> 
> If you are doing this please also use devm_input_allocate_device() and
> devm_regulator_bulk_get().

Now I remember: I can not switch to devm_regulator_bulk_get() unfortunately
since when we boot with DT the code needs to reach up for the parent's dev to
get the needed regulator. If I use devm_regulator_bulk_get() the resource will
be bind to the parent dev and not to the vibra driver.

> I also think it is high time to get rid of
> dedicated work queue - cwq hasn't actually given you a separate therad
> for a while now and if you get rid of workqueue you can get ridof entire
> twl6040_vibra_remove().

I agree with the rest. I'll move both twl4030/6040 vibra to use
devm_input_allocate_device() and also I will move them to use system wide
workqueue.

I'm going to resend the series soon with the suggested changes.

Thanks,
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/