linux-kernel - Re: regression, bisected: openpty fails from 3.7 onwards without devpts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130111131802.2986ba61@bob.linux.org.uk>
Date:	Fri, 11 Jan 2013 13:18:02 +0000
From:	Alan Cox <alan@...ux.intel.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	Florian Westphal <fw@...len.de>, linux-kernel@...r.kernel.org,
	gaowanlong@...fujitsu.com, gregkh@...uxfoundation.org,
	frank@...htenheld.de
Subject: Re: regression, bisected: openpty fails from 3.7 onwards without
 devpts

On Fri, 11 Jan 2013 13:44:22 +0100
Jiri Slaby <jslaby@...e.cz> wrote:

> On 01/11/2013 01:41 PM, Florian Westphal wrote:
> > Jiri Slaby <jslaby@...e.cz> wrote:
> >> On 01/10/2013 11:51 PM, Jiri Slaby wrote:
> >>> On 01/10/2013 11:45 PM, Alan Cox wrote:
> >>>> So we should just fix TIOCGPTN on a pty with no suitable name
> >>>> answer to return -EINVAL
> >>>
> >>> Yes, I agree as I'm expressed in my second mail. Sorry for the
> >>> confusion.
> >>
> >> Does the attached patch help?
> > 
> > Yes, it does.  Thanks for fixing this.
> 
> Ok, now I'm not sure if we want the patch or to implement TIOCGPTN
> properly instead. Alan?

IMHO - fix now for the -rc tree where its clearly low risk, after that
whatever people feel like doing 8)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/