linux-kernel - Re: [patch] ibft: add a missing break statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130111145256.GA14496@fenchurch.internal.datastacks.com>
Date:	Fri, 11 Jan 2013 09:52:56 -0500
From:	Peter Jones <pjones@...hat.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Konrad Rzeszutek Wilk <konrad@...nel.org>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] ibft: add a missing break statement

On Fri, Jan 11, 2013 at 09:48:07AM +0300, Dan Carpenter wrote:
> The code works the same with or without the break.  It just looks a bit
> cleaner to not fall through.

Yeah, you're clearly right.

For those reading this, so you don't have to go check yourselves, the
line after the end of this diff is also a break; there's no further code
in that case.

> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Peter Jones <pjones@...hat.com>

> 
> diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
> index 3ee852c..c4b187c 100644
> --- a/drivers/firmware/iscsi_ibft.c
> +++ b/drivers/firmware/iscsi_ibft.c
> @@ -503,6 +503,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int type)
>  	case ISCSI_BOOT_TGT_NIC_ASSOC:
>  	case ISCSI_BOOT_TGT_CHAP_TYPE:
>  		rc = S_IRUGO;
> +		break;
>  	case ISCSI_BOOT_TGT_NAME:
>  		if (tgt->tgt_name_len)
>  			rc = S_IRUGO;

-- 
        Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/