linux-kernel - Re: [PATCH v2] input: Extend matrix-keypad device tree binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130111171343.GE11224@core.coreip.homeip.net>
Date:	Fri, 11 Jan 2013 09:13:43 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Simon Glass <sjg@...omium.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Roland Stigge <stigge@...com.de>,
	Vincent Palatin <vpalatin@...omium.org>,
	linux-doc@...r.kernel.org, Wolfram Sang <w.sang@...gutronix.de>,
	Felipe Balbi <balbi@...com>,
	Luigi Semenzato <semenzato@...omium.org>,
	Rob Herring <rob.herring@...xeda.com>,
	linux-input@...r.kernel.org, Stephen Warren <swarren@...dia.com>,
	Sourav Poddar <sourav.poddar@...com>,
	Alban Bedel <alban.bedel@...onic-design.de>,
	devicetree-discuss@...ts.ozlabs.org,
	Laxman Dewangan <ldewangan@...dia.com>
Subject: Re: [PATCH v2] input: Extend matrix-keypad device tree binding

On Fri, Jan 11, 2013 at 10:09:19AM -0700, Stephen Warren wrote:
> On 01/10/2013 06:41 PM, Simon Glass wrote:
> > Some matrix keypad drivers can support different numbers of rows and
> > columns. Add a generic binding for these.
> > 
> > Implementation note:
> > 
> > In order to implement this binding in the kernel, we will need to modify
> > matrix_keypad_() to look up the number of rows and cols in
> > the keymap. Perhaps this could be done by passing 0 for these parameters?
> > Many of the parameters can already be set to NULL. Ick.
> 
> Reviewed-by: Stephen Warren <swarren@...dia.com>
> 
> Note that the Tegra bindings are based on matrix-keypad.txt, and
> recently added the following properties:
> 
> > - nvidia,kbc-row-pins: The KBC pins which are configured as row. This is an
> >   array of pin numbers which is used as rows.
> > - nvidia,kbc-col-pins: The KBC pins which are configured as column. This is an
> >   array of pin numbers which is used as column.
> 
> Those both define the number of rows/columns (indirectly via the
> property lengths) *and* define which pins are used for the rows/columns.
> How will this influence/interact-with any changes you're planning to the
> core matrix keymap parsing code; would Tegra require your "new"
> keypad,num-rows/keypad,num-columns properties even though the
> information is redundant, or will the Tegra driver have some way of
> passing this information to the core?

Even if we decide to move lookup of keypad,num-rows/keypad,num-columns
into matrix-keypad code we will still allow callers to override DT data,
like we do with platform keymaps.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/