lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <201301122112.25772.arnd@arndb.de> Date: Sat, 12 Jan 2013 21:12:25 +0000 From: Arnd Bergmann <arnd@...db.de> To: Thierry Reding <thierry.reding@...onic-design.de> Cc: Stephen Warren <swarren@...dotorg.org>, linux-tegra@...r.kernel.org, Grant Likely <grant.likely@...retlab.ca>, Rob Herring <rob.herring@...xeda.com>, Russell King <linux@....linux.org.uk>, Bjorn Helgaas <bhelgaas@...gle.com>, Andrew Murray <andrew.murray@....com>, Jason Gunthorpe <jgunthorpe@...idianresearch.com>, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>, devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org Subject: Re: [PATCH 10/14] PCI: tegra: Move PCIe driver to drivers/pci/host On Saturday 12 January 2013, Thierry Reding wrote: > > I already hinted at that in one of the other subthreads. Having such a > > multiplex would also allow the driver to be built as a module. I had > > already thought about this when I was working on an earlier version of > > these patches. Basically these would be two ops attached to the host > > bridge, and the generic arch_setup_msi_irq() could then look that up > > given the struct pci_dev that is passed to it and call this new per- > > host bridge .setup_msi_irq(). > > struct pci_ops looks like a good place to put these. They'll be > available from each struct pci_bus, so should be easy to call from > arch_setup_msi_irq(). > > Any objections? > struct pci_ops has a long history of being specifically about config space read/write operations, so on the one hand it does not feel like the right place to put interrupt specific operations, but on the other hand, the name sounds appropriate and I cannot think of any other place to put this, so it's fine with me. The only alternative I can think of is to introduce a new structure next to it in struct pci_bus, but that feels a bit pointless. Maybe Bjorn has a preference one way or the other. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists