linux-kernel - Re: Oops on aoe module removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1358055265.4514.67.camel@deadeye.wl.decadent.org.uk>
Date:	Sun, 13 Jan 2013 05:34:25 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Ed Cashin <ecashin@...aid.com>
Cc:	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Jens Axboe <axboe@...nel.dk>, Josh Boyer <jwboyer@...hat.com>,
	"mitko@...ksoft-bg.com" <mitko@...ksoft-bg.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-team@...oraproject.org" <kernel-team@...oraproject.org>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: Oops on aoe module removal

On Thu, 2013-01-03 at 15:20 -0600, Ed Cashin wrote:
> On Jan 3, 2013, at 3:50 PM, Ed Cashin wrote:
[...]
> > Kernels with aoe v47 can use the patch I just posted.
> > 
> > I'm going to go through the stable kernels and check, but I believe kernels after
> > v47 but before commit 0a41409c5180 should apply the fix in 0a41409c5180:
> > 
> >  commit 0a41409c518083133e79015092585d68915865be
> >  Author: Ed Cashin <ecashin@...aid.com>
> >  Date:   Mon Dec 17 16:03:58 2012 -0800
> > 
> >      aoe: remove vestigial request queue allocation
> 
> ...
> 
> OK.  Looks like 3.7.1 has aoe v50, exhibits the behavior in question, and needs
> the above-mentioned commit 0a41409c5180 from Linus' tree as a fix.
> 
> The 3.6.11 kernel has aoe v47, so it and earlier stable kernels can use the patch
> I posted in this thread.
> 
> I'm sending this to stable@...r.kernel.org to ask Greg, Ben, and other stable
> maintainers (where's the list of stable kernel maintainers?) ...

There is Willy Tarreau looking after 2.6.32.y, Paul Gortmaker with
2.6.34.y and unofficially Herton Ronaldo Krzesinski with 3.5.7.y.
All stable maintainers should be reading stable@...r.kernel.org anyway.

> Should I send git-generated patches to stable@...r.kernel.org based on each
> linux-stable/linux-3.x,y branch?  There are only two cases, really: 3.7.y and others.
> I suppose 3.7.y can cherry pick from the mainline.
>
> What's the best way to do this?

Given that aoe is basically unchanged between Linux 2.6.32 and 3.6 I
agree that the one patch should be sufficient.  However your previous
patch was lacking a signoff or much of a commit message, so please do
re-post it with those.  The commit message should include a reference to
the corresponding mainline commit as you identified above.

Ben.

-- 
Ben Hutchings
Klipstein's 4th Law of Prototyping and Production:
                                    A fail-safe circuit will destroy others.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)