linux-kernel - your patch "x86, 8042: Enable A20 using KBC to fix S3 resume on some MSI laptops"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <50F3CAFD02000078000B52BE@nat28.tlf.novell.com>
Date:	Mon, 14 Jan 2013 08:08:13 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	<linux@...nbow-software.org>
Cc:	<dmitry.torokhov@...il.com>, <hpa@...ux.intel.com>,
	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	"Rafael J. Wysocki" <rjw@...k.pl>, <linux-kernel@...r.kernel.org>
Subject: your patch "x86, 8042: Enable A20 using KBC to fix S3 resume
 on some MSI laptops"

Ondrej,

I see two problems with this patch: For one, on a system without
i8042 the code at the place it got inserted ought to incur a stall of
1s (50us * I8042_CTL_TIMEOUT [10000] * 2). I believe that this
code should not be run before i8042_controller_check() completed
successfully, but at the very least the second call to
i8042_command() should be conditional upon the first being
successful (effectively halving the stall).

Second, considering that enabling A20 (even if just in a fake way),
is a core system operation, I don't think it belongs into a driver
that is only optionally present in the kernel.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/