linux-kernel - Re: [PATCH] genirq: Give warning when setup an already-setup non-shared irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1301141211500.7475@ionos>
Date:	Mon, 14 Jan 2013 12:16:24 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Chuansheng Liu <chuansheng.liu@...el.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] genirq: Give warning when setup an already-setup non-shared
 irq

On Thu, 10 Jan 2013, Chuansheng Liu wrote:
> 
> Meet the case when the request_threaded_irq() with the same irq
> is called twice continually, get the below mismatch info:
> "IRQ handler type mismatch for IRQ 323"

I have no idea where you get that from. The mismatch is printed with:

        if (!(new->flags & IRQF_PROBE_SHARED)) {
	   pr_err("Flags mismatch irq %d. %08x (%s) vs. %08x (%s)\n",
                       irq, new->flags, new->name, old->flags, old->name);

And its only printed when IRQF_PROBE_SHARED is not set. Your change
would cause printouts where no printouts are due and it'd change the
return value from EBUSY to EINVAL.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/