linux-kernel - Re: [PATCH RFC -next] Fix the trailing blank space issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Jan 2013 22:07:21 +0800
From:	Bin Wang <wbin00@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	Cong Ding <dinggnu@...il.com>, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH RFC -next] Fix the trailing blank space issue

Sorry for the late response.

It is not a big deal about the code formate. It just makes me 
uncomfortable since my editor has a highlight for the trailing space. 
The similar things are the two-space between words of document and so on.

It's surely better to formate the code. So I submit a patch while I just 
read and find these little things . I'm not sure if it is a waste of 
time for the maintainers.

On 12/07/2012 12:59 AM, Greg Kroah-Hartman wrote:
> On Thu, Dec 06, 2012 at 04:31:39PM +0000, Cong Ding wrote:
>> On Thu, Dec 06, 2012 at 08:06:06AM -0800, Greg Kroah-Hartman wrote:
>>> On Thu, Dec 06, 2012 at 03:42:20PM +0000, Cong Ding wrote:
>>>> On Thu, Dec 06, 2012 at 05:08:56PM +0800, Bin Wang wrote:
>>>>> This patch removes the trailing white space in fs/sysfs/mount.c.
>>>>>
>>>>> Signed-off-by: Bin Wang <wbin00@...il.com>
>>>>> ---
>>>>>   fs/sysfs/mount.c | 2 +-
>>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>> Hi Greg,
>>>>
>>>> I am not sure it is really necessary to remove all the trailing blank spaces
>>>> in the project. I have done a try by this shell command
>>>> $ find . -iname '*.[ch]' | xargs sed 's/\s\+$//g' -i
>>>> and find there are 2812 files/31712 lines with this issue.
>>> That's very true, why would you want to do this?
>>>
>>> This comes up every 6 months or so on the linux-kernel mailing list,
>>> please see the archives for previous responses to the topic.
>>>
>>> If you want, just slowly send patches to the different subsystem
>>> maintainers, to clean the issue up.
>> sorry for forgetting press "reply all" in the former email...
>>
>> Sending them slowly to different subsystem maintainers is a very bad idea,
>> because it wastes lots of time for both me and them. But the current situation
>> is that there are some people send this kind of patches in random time which
>> also is a kind of wasting their time.
>>
>> I think we'd better to find a solution, not only for the blank space issue,
>> but also all the coding style issues able to be fixed by scripts.
>>
>> I would suggest to write a series of scripts. And then announce a date
>> (preferably some holiday like Xmas) to run these scripts. The announce is to
>> avoid conflicts with other developers. It will save both developers' and
>> subsystem maintains' time, do you agree?
> No I do not, it's not a big issue at all.  As I said, look in the
> archives, this comes up every six months or so.
>
> greg k-h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/