linux-kernel - Re: [PATCH] perf tools: mark branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130114141808.GB1363@krava.brq.redhat.com>
Date:	Mon, 14 Jan 2013 15:18:08 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	linux-kernel@...r.kernel.org, peterz@...radead.org,
	acme@...hat.com, mingo@...e.hu, namhyung.kim@....com
Subject: Re: [PATCH] perf tools: mark branch_info maps as referenced

On Mon, Jan 14, 2013 at 03:02:45PM +0100, Stephane Eranian wrote:
> 
> As noticed by Jiri, the hist_entry->branch_info.to/from maps
> need to be marked as referenced to avoid problems later on.
> So we do this when the hist_entry is allocated.
> 
> Signed-off-by: Stephane Eranian <eranian@...gle.com>

Acked-by: Jiri Olsa <jolsa@...hat.com>

> --
> 
> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> index cb17e2a..ab35b82 100644
> --- a/tools/perf/util/hist.c
> +++ b/tools/perf/util/hist.c
> @@ -242,6 +242,14 @@ static struct hist_entry *hist_entry__new(struct hist_entry *template)
>  
>  		if (he->ms.map)
>  			he->ms.map->referenced = true;
> +
> +		if (he->branch_info) {
> +			if (he->branch_info->from.map)
> +				he->branch_info->from.map->referenced = true;
> +			if (he->branch_info->to.map)
> +				he->branch_info->to.map->referenced = true;
> +		}
> +
>  		if (symbol_conf.use_callchain)
>  			callchain_init(he->callchain);
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/