linux-kernel - Re: [PATCH v7u1 22/31] x86, boot: add fields to support load bzImage and ramdisk above 4G

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50F4452D.2060000@zytor.com>
Date:	Mon, 14 Jan 2013 09:49:33 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Borislav Petkov <bp@...en8.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jan Kiszka <jan.kiszka@....de>,
	Jason Wessel <jason.wessel@...driver.com>,
	linux-kernel@...r.kernel.org, Rob Landley <rob@...dley.net>,
	Matt Fleming <matt.fleming@...el.com>,
	Gokul Caushik <caushik1@...il.com>,
	Josh Triplett <josh@...htriplett.org>,
	Joe Millenbach <jmillenbach@...il.com>
Subject: Re: [PATCH v7u1 22/31] x86, boot: add fields to support load bzImage
 and ramdisk above 4G

On 01/13/2013 09:37 PM, Yinghai Lu wrote:
>>
>> This is kinda missing from the mechanism of the sentinel and it should
>> be documented too.
>
> No, we should have too much duplicated info.
>

That is not duplicating info... that is basic documentation.  As you 
show in the post further on, it took a very simple description, and it 
*is* a very subtle thing that is inherently different from how the other 
fields operate.

It doesn't help that you didn't, despite repeated requests, implement 
what I *asked for*, which is:

If the sentinel is flagged, zero *all fields not explicitly set by the 
broken versions of kexec*, not just your new "ext" fields.

Yinghai, I understand you're frustrated, but please understand that 
Borislav is not in any shape, way, or form "some guys that do not know 
the code well keep sending comments out to waste others time".  Rather, 
he has spent a huge amount of time giving you an awful lot of good 
feedback  A lot of them have centered on documentation and code 
maintainability, both of which are vitally important part of a 
long-lived codebase.

Having someone doing line-by-line review of your code is enormously 
time-consuming and not something most people enjoy doing.  Borislav is 
doing you -- and me -- a huge favor here.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/