linux-kernel - Re: [PATCH v7u1 22/31] x86, boot: add fields to support load bzImage and ramdisk above 4G

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQUtbpo0njyPjPED=esKKnSdFs9ry4pFjG1y0LvHxkqV4w@mail.gmail.com>
Date:	Mon, 14 Jan 2013 11:50:20 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Borislav Petkov <bp@...en8.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jan Kiszka <jan.kiszka@....de>,
	Jason Wessel <jason.wessel@...driver.com>,
	linux-kernel@...r.kernel.org, Rob Landley <rob@...dley.net>,
	Matt Fleming <matt.fleming@...el.com>,
	Gokul Caushik <caushik1@...il.com>,
	Josh Triplett <josh@...htriplett.org>,
	Joe Millenbach <jmillenbach@...il.com>
Subject: Re: [PATCH v7u1 22/31] x86, boot: add fields to support load bzImage
 and ramdisk above 4G

On Mon, Jan 14, 2013 at 10:59 AM, H. Peter Anvin <hpa@...or.com> wrote:
> No, there were other fields that were also left uninitialized, per your
> analysis from last year.  I don't remember the details, but I seem to
> recall they included the EFI and graphics-related fields.
>
> So yes, just zero them all out.

?

+static void sanitize_real_mode(struct boot_params *real_mode)
+{
+       if (real_mode->sentinel) {
+               /*fields in boot_params are not valid, clear them */
+               memset(&real_mode->olpc_ofw_header, 0,
+                      (char *)&real_mode->alt_mem_k -
+                       (char *)&real_mode->olpc_ofw_header);
+               memset(&real_mode->_pad7[0], 0,
+                      (char *)&real_mode->edd_mbr_sig_buffer[0] -
+                       (char *)&real_mode->_pad7[0]);
+               memset(&real_mode->_pad8[0], 0,
+                      (char *)&real_mode->eddbuf[0] -
+                       (char *)&real_mode->_pad8[0]);
+               memset(&real_mode->_pad9[0], 0, sizeof(real_mode->_pad9));
+       }
+}
+
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/