linux-kernel - Re: [PATCH] spi: erase pointer to drvdata on removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <509501101.524434.1358198662068.JavaMail.root@mail.savoirfairelinux.com>
Date:	Mon, 14 Jan 2013 16:24:22 -0500 (EST)
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH] spi: erase pointer to drvdata on removal

Hi Mark, Grant,

> On Mon, 14 Jan 2013 02:51:45 +0000, Mark Brown
> <broonie@...nsource.wolfsonmicro.com> wrote:
> > On Thu, Nov 01, 2012 at 02:05:36PM -0400, Vivien Didelot wrote:
> > > As for i2c-core, let the SPI core handle the removal of the
> > > device's
> > > drvdata, after a remove() or a probe() failure.
> > 
> > Any driver that notices this change is buggy, the driver shouldn't
> > use a drvdata value that it didn't set.  I had thought this stuff
> > had
> > all been removed from I2C and either dropped or factored out into
> > the
> > driver core...
> 
> Looks to me like __device_release_driver() in drivers/base/dd.c
> already
> does this.
> 
> g.

You are right, I figured this out after the resend of this patch, see my reply here:
https://lkml.org/lkml/2012/12/4/224

    -Vivien
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/