linux-kernel - Re: [PATCH v7 0/4] PCI: pciehp, shpchp deadlock fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50F35FC0.2000507@huawei.com>
Date:	Mon, 14 Jan 2013 09:30:40 +0800
From:	Yijing Wang <wangyijing@...wei.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
CC:	<linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Daniel J Blueman <daniel@...ra.org>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Tejun Heo <tj@...nel.org>, Yinghai Lu <yinghai@...nel.org>,
	Jiang Liu <liuj97@...il.com>
Subject: Re: [PATCH v7 0/4] PCI: pciehp, shpchp deadlock fixes

On 2013/1/14 7:27, Bjorn Helgaas wrote:
> This is v7 of Yijing Wang's pciehp deadlock fix.  Here's the history of
> previous postings:
> 
>     RFC Oct 31 2012
>     v2  Nov  9 2012  use slot name, not device name
>     v3  Nov 12 2012  create workqueues in pcie_init_slot(), pciehp-%u format
>     v4  Nov 13 2012  use alloc_workqueue(name, 0, 0) again
>     v5  Jan  9 2013  fix similar problem in shpchp
>     v6  Jan 10 2013  add pciehp backtrace from Daniel 
> 
> This v7 series is functionally identical to v6.  In v7, I split the single
> shpchp patch into three:
> 
>     PCI: shpchp: Make shpchp_wq non-ordered
>     PCI: shpchp: Handle push button event asynchronously
>     PCI: shpchp: Use per-slot workqueues to avoid deadlock
> 

Nice, split the single patch into three will make the log clearer about the
code changes.

> The first fixes what appears to be an error in e24dcbef93 ("shpchp: update
> workqueue usage").  I split this out so Tejun could easily review it by itself.
> 
> I split the second out because it corresponds to a pciehp bugfix, 486b10b9f4
> ("PCI: pciehp: Handle push button event asynchronously"), that also affects
> shpchp.
> 
> The "PCI: shpchp: Use per-slot workqueues to avoid deadlock" that remains
> then corresponds exactly to Yijing's original pciehp deadlock fix.
> 
> I also rewrote the changelogs.
> 
> I propose to push the entire series for inclusion in v3.8, since it
> fixes an easy-to-cause deadlock with Thunderbolt adapters.
> 
> ---
> 
> Bjorn Helgaas (3):
>       PCI: shpchp: Make shpchp_wq non-ordered
>       PCI: shpchp: Handle push button event asynchronously
>       PCI: shpchp: Use per-slot workqueues to avoid deadlock
> 
> Yijing Wang (1):
>       PCI: pciehp: Use per-slot workqueues to avoid deadlock
> 
> 
>  drivers/pci/hotplug/pciehp.h      |    2 +-
>  drivers/pci/hotplug/pciehp_core.c |   11 ++---------
>  drivers/pci/hotplug/pciehp_ctrl.c |    8 ++++----
>  drivers/pci/hotplug/pciehp_hpc.c  |   11 ++++++++++-
>  drivers/pci/hotplug/shpchp.h      |    3 +--
>  drivers/pci/hotplug/shpchp_core.c |   36 ++++++++++++++----------------------
>  drivers/pci/hotplug/shpchp_ctrl.c |    6 +++---
>  7 files changed, 35 insertions(+), 42 deletions(-)
> 
> 


-- 
Thanks!
Yijing

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/