linux-kernel - Re: [PATCH v2] mtd: vt8500: Add support for Wondermedia Serial Flash Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Jan 2013 12:30:41 +1300
From:	Tony Prisk <linux@...sktech.co.nz>
To:	dedekind1@...il.com
Cc:	David Woodhouse <dwmw2@...radead.org>,
	vt8500-wm8505-linux-kernel@...glegroups.com,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] mtd: vt8500: Add support for Wondermedia Serial
 Flash Controller

On Tue, 2013-01-15 at 21:11 +0200, Artem Bityutskiy wrote:
> On Wed, 2013-01-16 at 06:45 +1300, Tony Prisk wrote:
> > On Tue, 2013-01-15 at 16:55 +0200, Artem Bityutskiy wrote:
> > > On Mon, 2012-12-31 at 10:00 +1300, Tony Prisk wrote:
> > > > This patch adds support for the Wondermedia serial flash controller
> > > > found on WM8505, WM8650 and WM8850 SoCs.
> > > > 
> > > > Signed-off-by: Tony Prisk <linux@...sktech.co.nz>
> > > > ---
> > > > v2: Whitespace tidyup
> > > 
> > > Hi, would you please take a look at these warings, identified by aiaiai:
> > > 
> > > Successfully built configuration "x86_64_defconfig,x86_64,", results:
> > > 
> > > --- before_patching.log
> > > +++ after_patching.log
> > > @@ @@
> > > +drivers/mtd/devices/wmt_sflash.c: In function ‘sf_read’:
> > > +drivers/mtd/devices/wmt_sflash.c:425:9: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat]
> > > +drivers/mtd/devices/wmt_sflash.c: In function ‘sf_sector_write’:
> > > +drivers/mtd/devices/wmt_sflash.c:442:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> > > +drivers/mtd/devices/wmt_sflash.c:442:24: warning: cast removes address space of expression [sparse]
> > > +drivers/mtd/devices/wmt_sflash.c:458:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > > +drivers/mtd/devices/wmt_sflash.c:458:31: warning: incorrect type in argument 1 (different address spaces) [sparse]
> > > +drivers/mtd/devices/wmt_sflash.c:458:31:    expected void volatile [noderef] <asn:2>*dst [sparse]
> > > +drivers/mtd/devices/wmt_sflash.c:458:31:    got unsigned char [usertype] *<noident> [sparse]
> > > +drivers/mtd/devices/wmt_sflash.c:465:17: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > > +drivers/mtd/devices/wmt_sflash.c:465:39: warning: incorrect type in argument 1 (different address spaces) [sparse]
> > > +drivers/mtd/devices/wmt_sflash.c:465:39:    expected void volatile [noderef] <asn:2>*dst [sparse]
> > > +drivers/mtd/devices/wmt_sflash.c:465:39:    got unsigned char [usertype] *<noident> [sparse]
> > > 
> > 
> > Apologies - This driver shouldn't be selectable for x86_64.
> > It is an ARM driver for an embedded device. Will fix.
> 
> Note, there are also warnings when it is compiled for other platforms,
> not only x86_64. Take a look at them. Also note, than many warnings come
> from sparse, you probably just did not run it.
> 

I posted the patch for this problem this morning. It should only be
selectable on arch-vt8500 and the new patch fixes this problem.

It incorrectly depended on MTD rather than ARCH_VT8500

Regards
Tony P

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/