linux-kernel - [PATCH] gpu: drm/gma500/mdfld_dsi_output.c: remove unnecessary null pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 15 Jan 2013 01:30:57 +0100
From:	Cong Ding <dinggnu@...il.com>
To:	David Airlie <airlied@...ux.ie>, Dave Airlie <airlied@...hat.com>,
	Alan Cox <alan@...ux.intel.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Zhao Yakui <yakui.zhao@...el.com>, Rob Clark <rob@...com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc:	Cong Ding <dinggnu@...il.com>
Subject: [PATCH] gpu: drm/gma500/mdfld_dsi_output.c: remove unnecessary null pointer check

the variable sender is dereferenced in line 95, so it is no reason to check
null again in line 99.

Signed-off-by: Cong Ding <dinggnu@...il.com>
---
 drivers/gpu/drm/gma500/mdfld_dsi_output.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_output.c b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
index 2d4ab48..67e439a 100644
--- a/drivers/gpu/drm/gma500/mdfld_dsi_output.c
+++ b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
@@ -96,11 +96,6 @@ void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe)
 	struct drm_psb_private *dev_priv = dev->dev_private;
 	u32 gen_ctrl_val;
 
-	if (!sender) {
-		DRM_ERROR("No sender found\n");
-		return;
-	}
-
 	/* Set default display backlight value to 85% (0xd8)*/
 	mdfld_dsi_send_mcs_short(sender, write_display_brightness, 0xd8, 1,
 				true);
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/