linux-kernel - Re: [PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vee+2PTzxnd0zQ1zeR437uKj_bRV-Pbb5g7O+CfaUb2aw@mail.gmail.com>
Date:	Tue, 15 Jan 2013 11:36:11 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Vinod Koul <vinod.koul@...el.com>,
	linux-kernel@...r.kernel.org, spear-devel <spear-devel@...t.st.com>
Subject: Re: [PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width

On Tue, Jan 15, 2013 at 11:09 AM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> On 15 January 2013 14:38, Andy Shevchenko <andy.shevchenko@...il.com> wrote:
>> You forgot the mem2mem type of transfers where we have no information
>> about masters except default settings. Otherwise there is the case of
>> custom slave config absence when we supply only request line via
>> slave_id.
>
> Okay, but even for mem2mem you have just got the right bus width by
> selecting same master. But are you programming same masters in control
> register? I can't see that :(

Oops. Seems this patch does not cover the CTL lo register value.
Thank you for pointing this out. I will think how to make the fix better.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/