linux-kernel - Re: [PATCH] s390: kvm/sigp.c: fix memory leakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 Jan 2013 11:08:36 +0100
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Cong Ding <dinggnu@...il.com>
Cc:	Marcelo Tosatti <mtosatti@...hat.com>,
	Gleb Natapov <gleb@...hat.com>,
	Christian Borntraeger <borntraeger@...ibm.com>,
	linux390@...ibm.com, Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	kvm@...r.kernel.org, linux-s390@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390: kvm/sigp.c: fix memory leakage

On Mon, 14 Jan 2013 22:39:54 +0100
Cong Ding <dinggnu@...il.com> wrote:

> the variable inti should be freed in the branch CPUSTAT_STOPPED.
> 
> Signed-off-by: Cong Ding <dinggnu@...il.com>
> ---
>  arch/s390/kvm/sigp.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/s390/kvm/sigp.c b/arch/s390/kvm/sigp.c
> index 461e841..1c48ab2 100644
> --- a/arch/s390/kvm/sigp.c
> +++ b/arch/s390/kvm/sigp.c
> @@ -137,8 +137,10 @@ static int __inject_sigp_stop(struct kvm_s390_local_interrupt *li, int action)
>  	inti->type = KVM_S390_SIGP_STOP;
> 
>  	spin_lock_bh(&li->lock);
> -	if ((atomic_read(li->cpuflags) & CPUSTAT_STOPPED))
> +	if ((atomic_read(li->cpuflags) & CPUSTAT_STOPPED)) {
> +		kfree(inti);
>  		goto out;
> +	}
>  	list_add_tail(&inti->list, &li->list);
>  	atomic_set(&li->active, 1);
>  	atomic_set_mask(CPUSTAT_STOP_INT, li->cpuflags);

Thanks, applied.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/