linux-kernel - Re: [RFC PATCH 2/7] ARM: OMAP: devices: create device for usb part of control module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50F5514A.2040207@mvista.com>
Date:	Tue, 15 Jan 2013 16:53:30 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Kishon Vijay Abraham I <kishon@...com>
CC:	grant.likely@...retlab.ca, b-cousson@...com,
	rob.herring@...xeda.com, rob@...dley.net, linux@....linux.org.uk,
	arnd@...db.de, balbi@...com, tony@...mide.com,
	devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [RFC PATCH 2/7] ARM: OMAP: devices: create device for usb part
 of control module

Hello.

On 15-01-2013 12:42, Kishon Vijay Abraham I wrote:

> A seperate driver has been added to handle the usb part of control
> module. A device for the above driver is created here, using the register
> address information to be used by the driver for powering on the PHY and
> for writing to the mailbox.

> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> ---
>   arch/arm/mach-omap2/devices.c |   50 +++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 50 insertions(+)

> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index 5e304d0..a761faf4 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
[...]
> @@ -254,6 +255,54 @@ static inline void omap_init_camera(void)
>   #endif
>   }
>
> +#if (defined(CONFIG_OMAP_CONTROL_USB) || \
> +				defined(CONFIG_OMAP_CONTROL_USB_MODULE))

    () around || not needed, and you're indenting the second line too much.

> +static inline void __init omap_init_control_usb(void)
> +{
> +	int ret = 0;

    Initializer not needed.

> +
> +	if (cpu_is_omap44xx()) {
> +		ret = platform_device_register(&omap4_control_usb);
> +		if (ret)
> +			pr_err("Error registering omap_control_usb device: %d\n"
> +			    , ret);

    Please leave the comma on the previous line.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/