linux-kernel - RE: [PATCH 08/10] video: da8xx-fb: obtain fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C8443D0743D26F4388EA172BF4E2A7A93EA85B05@DBDE01.ent.ti.com>
Date:	Tue, 15 Jan 2013 13:59:03 +0000
From:	"Mohammed, Afzal" <afzal@...com>
To:	Steffen Trumtrar <s.trumtrar@...gutronix.de>
CC:	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	"Valkeinen, Tomi" <tomi.valkeinen@...com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>, "Nori, Sekhar" <nsekhar@...com>,
	"Hiremath, Vaibhav" <hvaibhav@...com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: RE: [PATCH 08/10] video: da8xx-fb: obtain fb_videomode info from dt

Hi Steffen,

On Mon, Jan 07, 2013 at 14:51:15, Mohammed, Afzal wrote:
> On Mon, Jan 07, 2013 at 14:41:31, Steffen Trumtrar wrote:
> > On Mon, Jan 07, 2013 at 10:41:30AM +0530, Afzal Mohammed wrote:

> > > +- display-timings: list of different videomodes supported by the lcd
> > > +  panel, represented as childs, can have multiple modes supported, if
> > > +  only one, then it is considered native mode, if multiple modes are
> > > +  provided, native mode can be set explicitly, more details available
> > > +  @Documentation/devicetree/bindings/video/display-timing.txt
> 
> > Keep in mind that the text combined with...
> 
> > > +		if (of_get_fb_videomode(np, lcdc_info, 0)) {
> > > +			dev_err(&dev->dev, "timings not available in DT\n");
> > > +			return NULL;
> > > +		}
> > > +		return lcdc_info;
> > > +	}
> > 
> > ... this is not correct. You are just supporting the first display-timings
> > subnode (of_get_fb_videomode(..., 0)).
> 
> 
> Yes right, I will modify the text to reflect what the driver does.

Thinking about it further, it seems the right thing to do
in this case would be to invoke as,

"of_get_fb_videomode(np, lcd_info, OF_USE_NATIVE_MODE)".

Updated version has been posted to the lists (forgot to cc you)

Regards
Afzal