linux-kernel - Re: [PATCH v8 08/22] PCI, acpiphp: Separate out hot-add support of pci host bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQWCg9ZF8mXF-fMKUhOXF=EDeS07BWKvUSDxWUxikrQu4w@mail.gmail.com>
Date:	Tue, 15 Jan 2013 07:54:22 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Len Brown <lenb@...nel.org>,
	Taku Izumi <izumi.taku@...fujitsu.com>,
	Jiang Liu <jiang.liu@...wei.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v8 08/22] PCI, acpiphp: Separate out hot-add support of
 pci host bridge

On Mon, Jan 14, 2013 at 10:44 PM, Yinghai Lu <yinghai@...nel.org> wrote:
> On Sat, Jan 12, 2013 at 3:18 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
>>> @@ -673,3 +673,223 @@ int __init acpi_pci_root_init(void)
>>>
>>>       return 0;
>>>  }
>>> +
>>> +/*
>>> + * Separated from drivers/pci/hotplug/acpiphp_glue.c
>>> + *   only support root bridge
>>> + */
>>
>> This comment will be useless after applying the patch.
>>
>>> +
>>> +static LIST_HEAD(acpi_root_bridge_list);
>>> +struct acpi_root_bridge {
>>> +     struct list_head list;
>>> +     acpi_handle handle;
>>> +     u32 flags;
>>> +};
>>
>> We have struct acpi_pci_root already.  Why do we need this in addition?
>
> will address that in following patch.

please check if you are ok with merging attached 5 patches in to one
patches instead.

Thanks

Yinghai

Download attachment "pci_root_acpiphp_split_before_jiang_hotplug_rework.patch" of type "application/octet-stream" (10334 bytes)

Download attachment "pci_root_hp_1.patch" of type "application/octet-stream" (3084 bytes)

Download attachment "kill_remove_acpi_root_bridge.patch" of type "application/octet-stream" (5630 bytes)

Download attachment "root_bridge_remove_2.patch" of type "application/octet-stream" (2523 bytes)