linux-kernel - Re: [PATCH 2/2] decompressors: make the default XZ_BCJ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130115201117.5ce0a690@tukaani.org>
Date:	Tue, 15 Jan 2013 20:11:17 +0200
From:	Lasse Collin <lasse.collin@...aani.org>
To:	Florian Fainelli <florian@...nwrt.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] decompressors: make the default XZ_BCJ_* config
 match the selected architecture

On 2013-01-15 Florian Fainelli wrote:
> This patch changes the defautl XZ_BCJ_* config symbol to match the
> configured architecture. It is perfectly legitimate to support
> multiple XZ BCJ filters for different architectures (e.g.: to mount
> foreign squashfs/xz compressed filesystems), it is however more
> natural not to select them all by default, but only the one matching
> the configured architecture.

I don't have a strong opinion on what is the best default setting, so
it's fine to me that the default is changed if that's what people
prefer.

>  config XZ_DEC_X86
>  	bool "x86 BCJ filter decoder" if EXPERT
> -	default y
> +	default y if X86
>  	select XZ_DEC_BCJ
[...]

I think the "if EXPERT" strings should be dropped when all BCJ filters
aren't enabled by default. One should be able to enable all filters
without enabling EXPERT.

-- 
Lasse Collin  |  IRC: Larhzu @ IRCnet & Freenode
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/