linux-kernel - Re: [PATCH v2] hwmon: (sht15) check GPIO directions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130115193611.GA22507@roeck-us.net>
Date:	Tue, 15 Jan 2013 11:36:11 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	lm-sensors@...sensors.org, Jean Delvare <khali@...ux-fr.org>,
	linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com
Subject: Re: [PATCH v2] hwmon: (sht15) check GPIO directions

On Tue, Jan 15, 2013 at 01:33:06PM -0500, Vivien Didelot wrote:
> Without this patch, the SHT15 driver may fail silently with a
> non-bidirectional data line and/or an input-only clock line.
> 
> This patch checks the return value of gpio_direction_* function calls
> and returns the error code (if any) to the caller. If an error occurs in
> the read work function (work_funct_t), we wake the queue up directly
> without updating the data->state flag, to notice the waiter of the I/O
> error.
> 
> The patch also makes minor cleanups: s/error_ret/unlock for some labels
> and uses devm_gpio_request_one() for the clock line.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Applied to -next.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/