Message-Id: <201301152327.49010.yann.morin.1998@free.fr>
Date:	Tue, 15 Jan 2013 23:27:48 +0100
From:	"Yann E. MORIN" <yann.morin.1998@...e.fr>
To:	Roland Eggner <edvx1@...temanalysen.net>
Cc:	linux-kbuild@...r.kernel.org, Dmitry Voytik <dvv.kernel@...il.com>,
	Michal Marek <mmarek@...e.cz>,
	Stephen Boyd <sboyd@...eaurora.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] nconf:  add keybindings for vi-style menu navigation, rewrite help texts

Roland, All,

On Tuesday 15 January 2013 Roland Eggner wrote:
> >From: Roland Eggner <edvx1@...temanalysen.net>

OK, now I've had time to test it. Works OK.

However, this patch mixes different things: feature changes, help-texts
rewrite...

Could you split it into multiple patches, each do a single, well-defined
change? See below.

> •  Implemented vi-style navigation <k> <j> <l> <h>, based on initial work by
>    Dmitry Voytik.  Using <?> <H> instead of <?> <h> for help related to current
>    menu entry avoids conflict.
> 
> •  Added keybindings <C-n> <C-p> additionally to <C-f> <C-b> for moving pagewise
>    down and up.  <C-f> <C-b> is used for characterwise right and left movement
>    by libreadline (bash, xfsprogs, bc, gdb, python, ruby, hunspell, mysql,
>    sqlite, gnupg, xine-ui, parted …).  Thus pagewise movement by <C-n> <C-p> is
>    less confusing than by <C-f> <C-b> for my fingers.

I think we should only retain the more "natural" key bindings: <C-f> and
<C-b> for left/right. <C-p> and <C-n> are not for PAge-Up/Down, but for
previous-in-history and next-in-history (which, IMHO, is not the same
meaning).

However, I wonder how many such *-like keys we should have.

The up/down and Page-Up/Down keys are really trivially understood. It's
been a long while ago they were introduced in vim (rather than using the
oldish hjkl). Readline also understands those arrow-keys keys. So, really,
I wonder what the point of having these new keys is.

> •  Rewrote all help texts.  During several years lazy (incomplete) updates had
>    left behind a rather thick layer of dust.  Intentions:
>    (1)  Global help called by <F1> should document all  _currently_  implemented
>         keybindings.
>    (2)  Different help texts called by <F3> resp. <F8><F1> should be consistent
>         with (1) and with implementation:
>         •  on plain menu entry
>         •  in radiolist window
>         •  in input windows for text, decimal or hexadecimal values
>         •  in filename selection windows <F6> <F7>
>         •  SymSearch specific help called by <F8> followed by <F1>

This one does indeed give an easier to read, more precise and more complete
help. This should be a separate patch.

> •  Function keys line:  “Help 2” instead of “Insts” and “ShowAll” instead of
>    “Config” should be more intuitiv.

Ditto, a separate patch.

I'd suggest that you add the least controversial patches first, and submit
them as four patches:
  - help rewrite
  - labels rewrite (update help accordingly)
  - vi-like keys
  - readline-like keys

(Or the other way around for the last two patches.)

With this patch ordering, each patch is easier to review, the fixes ones
(help and labels rewrites) can be easily applied, and we can discuss the
last two separately.

Thank you!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists