linux-kernel - Re: [PATCH] sched: reduce sched_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r4llnbed.fsf@sejong.aot.lge.com>
Date:	Wed, 16 Jan 2013 10:51:06 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	liguang <lig.fnst@...fujitsu.com>
Cc:	mingo@...hat.com, peterz@...radead.org, Morten.Rasmussen@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: reduce sched_domain_topology space

Hi, liguang

On Tue, 15 Jan 2013 17:15:18 +0800, liguang wrote:
> sched_domain_topology space was allocated by the size
> ARRAY_SIZE(default_topology) + sched_domains_numa_levels,
> suppose CONFIG_SCHED_SMT, CONFIG_SCHED_MC were y,
> "static struct sched_domain_topology_level default_topology[] = {
>          { sd_init_SIBLING, cpu_smt_mask, },
>          { sd_init_MC, cpu_coregroup_mask, },
>          { sd_init_CPU, cpu_cpu_mask, },
>          { NULL, },
> };"
> then, ARRAY_SIZE(default_topology) equals to 4,
> default_topology's NULL entry was accounted,
> but, the following allocation for other sched_domains_numa_levels
> entries was startd at 3(for default_topology[3].init is NULL),
> so, 1 entry was forgot.

I don't think it's forgotten.

The sched_domain_topology still needs NULL entry at the end.  So what
the current code does is to set up following sched_domain_topology:

{ default_topology (without last NULL entry), numa topology, NULL }

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/