linux-kernel - Re: [PATCH V2] memory-hotplug: revert register_page_bootmem_info_node() to empty when platform related code is not implemented

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50F60BDE.8050304@cn.fujitsu.com>
Date:	Wed, 16 Jan 2013 10:09:34 +0800
From:	Lin Feng <linfeng@...fujitsu.com>
To:	Michal Hocko <mhocko@...e.cz>
CC:	akpm@...ux-foundation.org, linux-mm@...ck.org,
	kamezawa.hiroyu@...fujitsu.com, mel@....ul.ie, minchan@...nel.org,
	aquini@...hat.com, wency@...fujitsu.com, jiang.liu@...wei.com,
	laijs@...fujitsu.com, isimatu.yasuaki@...fujitsu.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] memory-hotplug: revert register_page_bootmem_info_node()
 to empty when platform related code is not implemented

Hi Michal,

On 01/15/2013 10:20 PM, Michal Hocko wrote:
>> +#else
>> > +void register_page_bootmem_info_node(struct pglist_data *pgdat)
>> > +{
>> > +	/* TODO */
>> > +}
> I think that TODO is misleading here because the function should be
> empty if !CONFIG_HAVE_BOOTMEM_INFO_NODE. I would also suggest updating
Yes, I got lost here, you are right, thanks.

> include/linux/memory_hotplug.h and removing the arch specific functions
> without any implementation. Something like (untested) patch below:
I will merge your suggestion in next version.

thanks,
linfeng
> ---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/