linux-kernel - RE: [PATCH] serial:ifx6x60:Keep word size accordance with SPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <253F3AA5ECB4EC43A2CA0147545F67F2102CE29F@SHSMSX102.ccr.corp.intel.com>
Date:	Wed, 16 Jan 2013 04:57:40 +0000
From:	"Bi, Chao" <chao.bi@...el.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	Alan Cox <alan@...ux.intel.com>,
	"Gorby, Russ" <russ.gorby@...el.com>,
	"Chen, Jun D" <jun.d.chen@...el.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] serial:ifx6x60:Keep word size accordance with SPI
 controller

Sorry for that, please check my resubmitted patch right now.

Thanks,
Chao

-----Original Message-----
From: Greg KH [mailto:gregkh@...uxfoundation.org] 
Sent: Wednesday, January 16, 2013 10:50 AM
To: Bi, Chao
Cc: Alan Cox; Gorby, Russ; Chen, Jun D; linux-serial@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial:ifx6x60:Keep word size accordance with SPI controller

On Wed, Dec 12, 2012 at 01:07:06PM +0800, chao bi wrote:
> 
> As protocol driver, IFX SPI driver initiate to setup SPI master with 
> default SPI word size as 16 bit/word, however, SPI master may not 
> adopt this default value due to SPI controller's capability, it might 
> choose an available value by itself and set it to 
> spi_device.bits_per_word. In order to keep align with Controller, IFX 
> driver should make use of this value during SPI transfer, but the default one.
> 
> Signed-off-by: Chen Jun <jun.d.chen@...el.com>
> Signed-off-by: channing <chao.bi@...el.com>
> ---
>  drivers/tty/serial/ifx6x60.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/tty/serial/ifx6x60.c 
> b/drivers/tty/serial/ifx6x60.c index 675d94a..5919992 100644
> --- a/drivers/tty/serial/ifx6x60.c
> +++ b/drivers/tty/serial/ifx6x60.c
> @@ -810,7 +810,8 @@ static void ifx_spi_io(unsigned long data)
>  		ifx_dev->spi_xfer.cs_change = 0;
>  		ifx_dev->spi_xfer.speed_hz = ifx_dev->spi_dev->max_speed_hz;
>  		/* ifx_dev->spi_xfer.speed_hz = 390625; */
> -		ifx_dev->spi_xfer.bits_per_word = spi_bpw;
> +		ifx_dev->spi_xfer.bits_per_word =
> +		ifx_dev->spi_dev->bits_per_word;

Please follow the proper coding style (hint, this isn't it.)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/