linux-kernel - Re: [PATCH 08/13] perf gtk/browser: Add support for event group view

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a9s9mnlt.fsf@sejong.aot.lge.com>
Date:	Wed, 16 Jan 2013 19:25:02 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Stephane Eranian <eranian@...gle.com>,
	Namhyung Kim <namhyung.kim@....com>,
	Pekka Enberg <penberg@...nel.org>
Subject: Re: [PATCH 08/13] perf gtk/browser: Add support for event group view

On Tue, 15 Jan 2013 15:34:05 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jan 15, 2013 at 04:31:52PM +0900, Namhyung Kim escreveu:
>> From: Namhyung Kim <namhyung.kim@....com>
>> 
>> Show group members' overhead also when showing the leader's if event
>> group is enabled.  Use macro for defining hpp functions which looks
>> almost identical.
>> 
>> Unlike other hpp backend, GTK+ needs to print dummy 0.00% output since
>> it's displayed with variable width fonts.  So that simply skipping
>> with %*s trick won't work well here.
>
> I'm illiterate on GTK+ internals, but I kinda expected that it could
> provide a way to avoid such things, i.e. a way to position the cursor
> in such circumstance without having to actually print the '0.00%' :-\

I also don't understand the internals so I just guess that it might
(only?) be acheived by adding new columns for each group members.

Of course I'm fine with this way too, but one thing I'm not sure is how
the column header look like.  Currently "Overhead" is displayed on the
header for period of every group members - say, there's a group consists
of two events: {branches,branch-misses}.  It'd look like:

        Overhead  Command  Shared Object   Symbol
  ..............  .......  .............  .......
  98.32%  31.16%    a.out          a.out  [.] foo


Maybe we can use simple event name for this, but it seems it makes to
hard to recognize which one is which if other output options like
--show-total-period, --showcpuutilization and/or --show-nr-samples.

Adding current header name to event name will fix the problem but it
probably occupies too much screen width especially for long named
tracepoint or PMU-specific events like
"compaction:mm_compaction_isolate_migratepages".

  Overhead/branches  Overhead/branch-misses  sys/branches  sys/branch-misses  usr/branches  usr/branch-misses  Command  Shared Object   Symbol
  .................  ......................  ............  .................  ............  .................  .......  .............  .......
             98.32%                  31.16%         0.00%              0.00%        98.32%             31.16%    a.out          a.out  [.] foo


If you have a better idea or other way to place the cursor without
printing bogus 0.00% on GTK, please let me know.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/