linux-kernel - Re: [PATCH] regmap: debugfs: Fix last entry store in the offset cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130116132918.GH25480@opensource.wolfsonmicro.com>
Date:	Wed, 16 Jan 2013 22:29:19 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] regmap: debugfs: Fix last entry store in the offset cache

On Wed, Jan 16, 2013 at 02:24:11PM +0100, Philipp Zabel wrote:

> -	/* Close the last entry off if we didn't scan beyond it */
> -	if (c) {
> -		c->max = p - 1;
> -		list_add_tail(&c->list,
> -			      &map->debugfs_off_cache);

Oh, ffs.  I actually fixed this but the cherry pick went wrong.

> -	} else {
> -		return base;
> +		/* Close the last entry off if we didn't scan beyond it */
> +		if (c) {
> +			c->max = p - 1;
> +			list_add_tail(&c->list,
> +				      &map->debugfs_off_cache);
> +		} else {
> +			return base;
> +		}

No, the else clause just needs deleting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/