lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <50f6bf2a.e2ee440a.7c4d.ffff97b8@mx.google.com>
Date:	Wed, 16 Jan 2013 22:53:34 +0800
From:	yix.x.zhang@...il.com
To:	cjb@...top.org
Cc:	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Zhang, Yi" <yix.x.zhang@...il.com>
Subject: [PATCH v2] mmc: correct one comment error of structure mmc_ext_csd

From: "Zhang, Yi" <yix.x.zhang@...il.com>

The right value for field raw_exception_status is 54(not 53) according
to eMMC 4.5 specification. Also for more readable, replace all number
values with macro symboles.

Signed-off-by: Zhang, Yi <yix.x.zhang@...il.com>
---
 include/linux/mmc/card.h |   34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
index 5c69315..d270392 100644
--- a/include/linux/mmc/card.h
+++ b/include/linux/mmc/card.h
@@ -83,23 +83,23 @@ struct mmc_ext_csd {
 	unsigned int            data_tag_unit_size;     /* DATA TAG UNIT size */
 	unsigned int		boot_ro_lock;		/* ro lock support */
 	bool			boot_ro_lockable;
-	u8			raw_exception_status;	/* 53 */
-	u8			raw_partition_support;	/* 160 */
-	u8			raw_rpmb_size_mult;	/* 168 */
-	u8			raw_erased_mem_count;	/* 181 */
-	u8			raw_ext_csd_structure;	/* 194 */
-	u8			raw_card_type;		/* 196 */
-	u8			out_of_int_time;	/* 198 */
-	u8			raw_s_a_timeout;		/* 217 */
-	u8			raw_hc_erase_gap_size;	/* 221 */
-	u8			raw_erase_timeout_mult;	/* 223 */
-	u8			raw_hc_erase_grp_size;	/* 224 */
-	u8			raw_sec_trim_mult;	/* 229 */
-	u8			raw_sec_erase_mult;	/* 230 */
-	u8			raw_sec_feature_support;/* 231 */
-	u8			raw_trim_mult;		/* 232 */
-	u8			raw_bkops_status;	/* 246 */
-	u8			raw_sectors[4];		/* 212 - 4 bytes */
+	u8			raw_exception_status;	/* EXT_CSD_EXP_EVENTS_STATUS */
+	u8			raw_partition_support;	/* EXT_CSD_PARTITION_SUPPORT */
+	u8			raw_rpmb_size_mult;	/* EXT_CSD_RPMB_MULT */
+	u8			raw_erased_mem_count;	/* EXT_CSD_ERASED_MEM_CONT */
+	u8			raw_ext_csd_structure;	/* EXT_CSD_STRUCTURE */
+	u8			raw_card_type;		/* EXT_CSD_CARD_TYPE */
+	u8			out_of_int_time;	/* EXT_CSD_OUT_OF_INTERRUPT_TIME */
+	u8			raw_s_a_timeout;	/* EXT_CSD_S_A_TIMEOUT */
+	u8			raw_hc_erase_gap_size;	/* EXT_CSD_HC_WP_GRP_SIZE */
+	u8			raw_erase_timeout_mult;	/* EXT_CSD_ERASE_TIMEOUT_MULT */
+	u8			raw_hc_erase_grp_size;	/* EXT_CSD_HC_ERASE_GRP_SIZE */
+	u8			raw_sec_trim_mult;	/* EXT_CSD_SEC_TRIM_MULT */
+	u8			raw_sec_erase_mult;	/* EXT_CSD_SEC_ERASE_MULT */
+	u8			raw_sec_feature_support;/* EXT_CSD_SEC_FEATURE_SUPPORT */
+	u8			raw_trim_mult;		/* EXT_CSD_TRIM_MULT */
+	u8			raw_bkops_status;	/* EXT_CSD_BKOPS_STATUS */
+	u8			raw_sectors[4];		/* EXT_CSD_SEC_CNT - 4 bytes */
 
 	unsigned int            feature_support;
 #define MMC_DISCARD_FEATURE	BIT(0)                  /* CMD38 feature */
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ