linux-kernel - Re: [PATCH v6 04/22] mfd: omap-usb-tll: Clean up clock handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130116145530.GU23505@n2100.arm.linux.org.uk>
Date:	Wed, 16 Jan 2013 14:55:30 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Roger Quadros <rogerq@...com>
Cc:	balbi@...com, sameo@...ux.intel.com, tony@...mide.com,
	sshtylyov@...sta.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, kishon@...com, bjorn@...k.no,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 04/22] mfd: omap-usb-tll: Clean up clock handling

On Wed, Jan 16, 2013 at 04:43:35PM +0200, Roger Quadros wrote:
> +	spin_lock_irqsave(&tll->lock, flags);
> +
> +	for (i = 0; i < tll->nch; i++) {
> +		char clkname[] = "usb_tll_hs_usb_chx_clk";
> +		struct clk *fck;
> +
> +		snprintf(clkname, sizeof(clkname),
> +					"usb_tll_hs_usb_ch%d_clk", i);
> +		fck = clk_get(dev, clkname);

NAK.  Why are you doing this under a spinlock?

clk_get() takes a mutex.  You must not be in an atomic region (iow, you
must not be holding a spinlock, and you must not have IRQs disabled)
when you call clk_get().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/