linux-kernel - Re: [PATCH] context_tracking: Add comments on interface and internals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFTL4hzkvYj=B5TS4p_k=mjLTBWCoZmOQ5G0JCqtU5xVZ8WCxQ@mail.gmail.com>
Date:	Wed, 16 Jan 2013 15:58:05 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Alessio Igor Bogani <abogani@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chris Metcalf <cmetcalf@...era.com>,
	Christoph Lameter <cl@...ux.com>,
	Geoff Levand <geoff@...radead.org>,
	Gilad Ben Yossef <gilad@...yossef.com>,
	Hakan Akkan <hakanakkan@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Li Zhong <zhong@...ux.vnet.ibm.com>,
	Namhyung Kim <namhyung.kim@....com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] context_tracking: Add comments on interface and internals

2013/1/16 Namhyung Kim <namhyung@...nel.org>:
> Hi Frederic,
>
> On Wed, 16 Jan 2013 13:32:57 +0100, Frederic Weisbecker wrote:
>> This subsystem lacks many explanations on its purpose and
>> design. Add these missing comments.
>>
>> v3: Fix the "hook" based naming as per Ingo's suggestion
> [snip]
>> +/**
>> + * context_tracking_task_switch - context switch the syscall callbacks
>
> To be more kernel-doc-friendly, it'd better adding descriptions for
> arguments too:
>
>  @prev: the task that is being switched out
>  @next: the task we are going to switch to

Right, I'm fixing that.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/