linux-kernel - Re: [PATCH 06/10] goldfish: emulated MMC device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130116171839.GD6377@arwen.pp.htv.fi>
Date:	Wed, 16 Jan 2013 19:18:39 +0200
From:	Felipe Balbi <balbi@...com>
To:	Alan Cox <alan@...ux.intel.com>
CC:	<arve@...roid.com>, <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>, <mikechan@...gle.com>
Subject: Re: [PATCH 06/10] goldfish: emulated MMC device

Hi,

On Wed, Jan 16, 2013 at 04:59:38PM +0000, Alan Cox wrote:
> +#define OMAP_MMC_CMDTYPE_BC	0
> +#define OMAP_MMC_CMDTYPE_BCR	1
> +#define OMAP_MMC_CMDTYPE_AC	2
> +#define OMAP_MMC_CMDTYPE_ADTC	3

OMAP ?? :-) If you guys are emulating an OMAP mmc controller, why don't
you just re-use the omap mmc driver instead of duplicating the code ?

same comments about devm_* and the GPL license

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)