linux-kernel - Re: [PATCH 2/4] staging: media: go7007: firmware protection Protection for unfirmware load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Jan 2013 15:03:23 -0300
From:	Ezequiel Garcia <elezegarcia@...il.com>
To:	Volokh Konstantin <volokh84@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	devel@...verdev.osuosl.org, mchehab@...hat.com,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	dhowells@...hat.com, rdunlap@...otime.net, hans.verkuil@...co.com,
	justinmattock@...il.com, linux-media@...r.kernel.org
Subject: Re: [PATCH 2/4] staging: media: go7007: firmware protection
 Protection for unfirmware load

Hi Volokh,

On Wed, Jan 16, 2013 at 10:42 AM, Volokh Konstantin <volokh84@...il.com> wrote:
> On Wed, Jan 16, 2013 at 04:35:45PM +0300, Dan Carpenter wrote:
>> The problem is that the firmware was being unloaded on disconnect?
>>
> If no firmware was loaded (no exists,wrong or some error) then rmmod fails with OOPS,
> so need some protection stuff

This explanation should be part of the commit message.
It helps people understand what you're doing and why it's needed.

BTW, none of this 4-patch series has a detailed commit message
besides the commit title.
I know they are small patches, but I'm sure you can do better than that!

-- 
    Ezequiel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/