linux-kernel - Re: [PATCH v2] hlist: drop the node parameter from iterators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFxFb21Ss=-0FUgzQOzPe1=mS11o7J-+Laco09XJvOk9Fg@mail.gmail.com>
Date:	Wed, 16 Jan 2013 12:48:48 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	Peter Senna Tschudin <peter.senna@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] hlist: drop the node parameter from iterators

On Sun, Jan 13, 2013 at 8:31 AM, Sasha Levin <sasha.levin@...cle.com> wrote:
> I'm not sure why, but the hlist for each entry iterators were conceived
> differently from the list ones. While the list ones are nice and elegant:

So this patch is probably the RightThing(tm) to do, but it's really
big and makes me nervous. And the fact that there was already one
problem in the first version doesn't make me feel any more
warm-and-fuzzy about it.

I understand that this kind of patch is nice to apply after the merge
window has closed, but at the same time, it's now *too* long after the
merge window closed, and even if it wasn't, I'd really like to feel
like this has gotten more testing than it obviously has. Or some other
guarantee that there isn't some other subtle issue hiding there.

So I am going through patches in my mbox, but I really don't feel safe
enough about this one to apply it.

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/