linux-kernel - Re: [PATCH 2/2] nfsd: fix compile warning about unused variable 'nn'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130116215719.GC6598@fieldses.org>
Date:	Wed, 16 Jan 2013 16:57:19 -0500
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	linux-nfs@...r.kernel.org,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] nfsd: fix compile warning about unused variable 'nn'

On Tue, Jan 15, 2013 at 09:43:07AM +0200, Mika Westerberg wrote:
> Commit c9a4962881 (nfsd: make client_lock per net) added
> lockdep_assert_held() call to function free_client(). However, if lockdep
> is disabled we get following compiler warning:
> 
> fs/nfsd/nfs4state.c: In function ‘free_client’:
> fs/nfsd/nfs4state.c:1051:19: warning: unused variable ‘nn’ [-Wunused-variable]
> 
> Fix this by marking the 'nn' with __maybe_unused.

I queued up fixes for these for 3.9 on the assumption it's better to
live with the compile errors a little longer than to submit unimportant
stuff for post-merge-window 3.8.

But if it means more people are going to waste time tripping over these,
then maybe they should just go in now--I don't know.

--b.

> 
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> ---
>  fs/nfsd/nfs4state.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index ac8ed96..2d3011c 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -1048,7 +1048,7 @@ static struct nfs4_client *alloc_client(struct xdr_netobj name)
>  static inline void
>  free_client(struct nfs4_client *clp)
>  {
> -	struct nfsd_net *nn = net_generic(clp->net, nfsd_net_id);
> +	struct nfsd_net *nn __maybe_unused = net_generic(clp->net, nfsd_net_id);
>  
>  	lockdep_assert_held(&nn->client_lock);
>  	while (!list_empty(&clp->cl_sessions)) {
> -- 
> 1.7.10.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/