linux-kernel - Re: [PATCH v6 03/22] mfd: omap-usb-tll: Use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Jan 2013 12:32:38 +0200
From:	Roger Quadros <rogerq@...com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
CC:	<balbi@...com>, <sameo@...ux.intel.com>, <tony@...mide.com>,
	<kishon@...com>, <bjorn@...k.no>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v6 03/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap
 and clean up error path

On 01/17/2013 11:12 AM, Roger Quadros wrote:
> On 01/16/2013 09:37 PM, Sergei Shtylyov wrote:
>> Hello.
>>
>> On 01/16/2013 05:43 PM, Roger Quadros wrote:
>>
>>> Use devm_ variants of kzalloc() and ioremap(). Simplify the error path.
>>
>>> Signed-off-by: Roger Quadros <rogerq@...com>
>>> ---
>>>  drivers/mfd/omap-usb-tll.c |   36 +++++++++++-------------------------
>>>  1 files changed, 11 insertions(+), 25 deletions(-)
>>
>>> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
>>> index 9658e18..53ed10b 100644
>>> --- a/drivers/mfd/omap-usb-tll.c
>>> +++ b/drivers/mfd/omap-usb-tll.c
>> [...]
>>> -	base = ioremap(res->start, resource_size(res));
>>> +	base = devm_request_and_ioremap(dev, res);
>>>  	if (!base) {
>>> -		dev_err(dev, "TLL ioremap failed\n");
>>>  		ret = -ENOMEM;
>>
>>    -EADDRNOTAVAIL as the comment to devm_request_and_ioremap() suggests.
>>
> 
> I changed it deliberately to ENOMEM, as I could not find EADDRNOTAVAIL
> defined in all architectures.
> 
> ENOMEM shouldn't harm.
> 

Correcting myself,

It is defined here

include/uapi/asm-generic/errno.h:#define        EADDRNOTAVAIL   99
/* Cannot assign requested address */

So i'll update both patches.

--
cheers,
-roger

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/