linux-kernel - Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbmgQ0xDfkbgqc=zDqMDUK0O6uQOf3kX9v1+=+N5s42bw@mail.gmail.com>
Date:	Thu, 17 Jan 2013 11:46:30 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Fabio Baltieri <fabio.baltieri@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Felipe Balbi <balbi@...com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Mian Yousaf KAUKAB <mian.yousaf.kaukab@...ricsson.com>
Subject: Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

On Thu, Jan 10, 2013 at 2:38 PM, Fabio Baltieri
<fabio.baltieri@...aro.org> wrote:
> On Thu, Jan 10, 2013 at 12:23:32PM +0100, Linus Walleij wrote:
>> On Mon, Jan 7, 2013 at 5:47 PM, Fabio Baltieri
>> <fabio.baltieri@...aro.org> wrote:
>>
>> > This patch converts the module to use clk_prepare_enable and
>> > clk_disable_unprepare variants as required by common clock framework.
>> >
>> > Without this the system crash during probe function.
>> >
>> > Signed-off-by: Fabio Baltieri <fabio.baltieri@...aro.org>
>>
>> Acked-by: Linus Walleij <linus.walleij@...aro.org>
>
> Thanks for the ACK.  This bug was here unnoticed since 3.6 merge window,

Then it should have Cc: stable@...nel.org..

> do you think it may make sense to add this driver to u8500_defconfig?  I
> can send a patch if you say so...

Yes, can you make a patch updating the defconfig and also enabling
a few other things like charging maybe? Sync with Lee.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/