linux-kernel - Re: [PATCH v2] sparc: kernel/sbus.c: fix memory leakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50F7D577.8010506@oldelvet.org.uk>
Date:	Thu, 17 Jan 2013 10:41:59 +0000
From:	Richard Mortimer <richm@...elvet.org.uk>
To:	Cong Ding <dinggnu@...il.com>
CC:	Sam Ravnborg <sam@...nborg.org>,
	"David S. Miller" <davem@...emloft.net>,
	sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] sparc: kernel/sbus.c: fix memory leakage



On 16/01/2013 22:01, Cong Ding wrote:
> the variable iommu and strbuf are not freed if it goes to error.
>
> Signed-off-by: Cong Ding <dinggnu@...il.com>
> ---
>   arch/sparc/kernel/sbus.c |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/sparc/kernel/sbus.c b/arch/sparc/kernel/sbus.c
> index 1271b3a..78aa26b 100644
> --- a/arch/sparc/kernel/sbus.c
> +++ b/arch/sparc/kernel/sbus.c
> @@ -656,6 +656,8 @@ static void __init sbus_iommu_init(struct platform_device *op)
>   	return;
>
>   fatal_memory_error:
> +	kfree(strbuf);

strbuf will be uninitialized if the iommu allocation fails. I don't have 
a particular preference for how to fix this but tend to dislike initial 
assignment with NULL because it hides other control flow issues.

Regards

Richard

> +	kfree(iommu);
>   	prom_printf("sbus_iommu_init: Fatal memory allocation error.\n");
>   }
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/